[libre-riscv-dev] [Bug 325] create POWER9 TRAP pipeline

bugzilla-daemon at libre-soc.org bugzilla-daemon at libre-soc.org
Sat Jun 6 00:46:06 BST 2020


--- Comment #61 from Cole Poirier <colepoirier at gmail.com> ---
(In reply to Luke Kenneth Casson Leighton from comment #58)
> yep, the pseudo-language is not documented, it's one of those things you
> have to look at other scripts and just work it out by inference.
> do a git pull on the libre-soc.org repo, i added the code to it there,
> you should find it works.
> one thing: you had a space in front of every line.  that would not have
> worked:
> the parser was written very very quickly.

Ah that's just when I pasted it here (I'm 90% sure), not in the file, for some
reason buzilla likes to prepend a space when I'm pasting code here.

(In reply to Luke Kenneth Casson Leighton from comment #59)
> (In reply to Cole Poirier from comment #57)
> > This is done. Should I start trying to figure out how to write these unit
> > tests using fu/cr/test/test_pipe_caller as a guide?
> yes sure.  although bear in mind that only the instructions which are
> supported
> in the emulator will work.

Oh interesting, is this our fork of gem5? Or is this  the one that is generated
from parsing the csv files? I recall this being discussed on list but I can't
remember which one we are currently using.

> > Or if this will be
> > outside of my current capacity, should I move on to bug #348?
> generally speaking if there are several tasks which you can do, just
> do another if you're blocked: don't wait to ask, just do it.

Don't worry, like 'waiting days or hours between commits' this is a bad habit
you helped me break a few weeks ago. I ended up working on Systemes Libres
stuff with Yehowshua for Wednesday's meeting. I'll be leaving this bug for now,
to work on bug #348. After I finish the pseudo-code translation for that, I
plan come back to do the unit tests for this, unless, as often happens with the
project, plans change.

> > > 2) add the pseudocode to sprset.mdwn (yes sprset.mdwn is a bad name) from
> > > comment #47
> > > 
> > > https://libre-soc.org/openpower/isa/sprset/
> > 
> > Waiting on your help with this one, I figured I shouldn't waste more time on
> > it given that it's likely something that you're capable of identifying and
> > fixing in a matter of seconds because you understand the parser completely.
> actually i don't: it has been several months, and i wrote it very fast,
> to perform a minimal job!
> i've done a git push on the libre-soc repo you should be able to retry.

Hmm yes, looking at the pseudo-code you've written there is no way I would have
figured out all of the necessary modifications to the spec pseudo code needed
to get the parser to validate it. Thanks for doing this for me, with this
knowledge I think I'll be able to do it solo next time.

You are receiving this mail because:
You are on the CC list for the bug.

More information about the libre-riscv-dev mailing list