[libre-riscv-dev] [Bug 316] bperm TODO

[bugzilla-daemon at libre-soc.org]

https://bugs.libre-soc.org/show_bug.cgi?id=316

--- Comment #72 from Luke Kenneth Casson Leighton <lkcl at lkcl.net> ---
(In reply to Cole Poirier from comment #71)
> (In reply to Luke Kenneth Casson Leighton from comment #70)
> > (In reply to Cole Poirier from comment #69)
> > > I have made the small code additions necessary to connect the Bperm module
> > > to the fu/logical pipeline, and added the test for this to
> > > test_pipe_caller.py. 
> > 
> > great.  if it passes, commit it, git pull, then push it.  let's take a look.
> 
> I can't run the test, see below.
> 
> > > Important question,
> > 
> > important _non-sequitur_ question.
> > 
> > > has soc.decoder.isa.all.ISA() been
> > > moved to soc.decoder.pseudo.pagereader.ISA()?
> > 
> > pagereader.ISA is for reading the ISA markdown files.  that is its job.
> > it creates a data structure that conveniently allows access in python
> > to the contents of those markdown files.
> > 
> > decoder.isa.all.ISA() is an auto-generated representation *of* the
> > pseudo-code - converted to python - for use by the simulator.
> > 
> > there is absolutely no relation whatsoever between the two tasks that
> > these two completely different modules perform, other than that, by
> > coincidence, pagereader.ISA happens to read the pseudocode that is
> > auto-oonverted to python and contained in decoder.isa.all.ISA()
> > 
> > hence why i am left puzzled and wondering - out of fascinated curiosity -
> > why there would be any reason why you imagine that one would be moved
> > to the other.
> > 
> > same name, perhaps?  was that it?
> 
> Yes, has caused an hour of headache. decoder/all.py is needed in order to
> run the tests. all.py is auto-generated, so is not present in the directory.
> How am I supposed to auto-generate it?

ah - you should have asked earlier :)  look in the Makefile:
    python3 src/soc/decoder/pseudo/pywriter.py


> Is it supposed to be autogenerated by
> the test itself?

no because it takes a good couple of minutes to go over the 300+ pseudo-code
code-fragments.

> This would be odd as the
> fu/logical/tests/test_pipe_caller.py file imports this at the top of the
> file. Essentially, help I am quite stuck after trying to solve this for an
> hour.

should have asked earlier :)

-- 
You are receiving this mail because:
You are on the CC list for the bug.