[libre-riscv-dev] [Bug 316] bperm TODO

[bugzilla-daemon at libre-soc.org]

https://bugs.libre-soc.org/show_bug.cgi?id=316

--- Comment #53 from Luke Kenneth Casson Leighton <lkcl at lkcl.net> ---
(In reply to Cole Poirier from comment #52)
> Michael, or Luke,
> 
> In order to add Bpermd to LogicalMainStage, it appears that I first have to
> add it to soc.decoder.power_enums.InternalOp,

line 102, it is already there.
remember use grep or in-editor search

i also use ctags (aptget install exuberant-ctags)

https://git.libre-soc.org/?p=soc.git;a=blob;f=src/soc/decoder/power_enums.py;h=690bf129381cb9ede1d0d92e3564440597fd9e3e;hb=HEAD

so with it already being there, the Case statement can be uncommented and code
added.  try just doing something small and innocuous to confirm that.


regarding code commits, if you make sure there are no syntax errors and second
that no other tests fail you're in the clear.

it is perfectly fine to commit a test that fails although decorating it as such
is generally better.

@unittest.skip("broken") or something if memory serves correctly.

-- 
You are receiving this mail because:
You are on the CC list for the bug.