[Libre-soc-bugs] [Bug 1228] SFFS ISACaller userspace ELF support for dynamic linking and PIC and statically-linked-glibc

[bugzilla-daemon at libre-soc.org]

https://bugs.libre-soc.org/show_bug.cgi?id=1228

--- Comment #20 from Luke Kenneth Casson Leighton <lkcl at lkcl.net> ---
(In reply to Jacob Lifshay from comment #19)
> (In reply to Luke Kenneth Casson Leighton from comment #18)
> > (In reply to Jacob Lifshay from comment #17)
> > 
> > > oh, actually, i think i should change the failing test to skip and merge the
> > > branch, this will help it from getting horribly out-of-date or forgotten.
> > > sound good?
> > 
> > good idea. or just leave it as a reminder.
> > 
> > it is perfectly fine to have tests that fail. that's what
> > they are there for, as reminders.
> 
> well, the problem with that is that CI won't show more than a few failing
> test cases (otherwise the log is too long and gitlab truncates it, removing
> the test summary), and also if we have too many, it's hard to find the tests
> we want because they get lost in the noise of known-failing test cases.
> > 
> > disabling tests "because fail" is actually extremely bad
> > practice. think it through as to why.
> 
> disabling tests because you broke them and won't fix them is bad practice,

agreed. and would not be permitted, and is not the case here.

> 
> disabling tests because you never completed them and know that and have a
> bug tracking them is imo fine.

ah no.  *attempting to run them and putting the bug URL in the @messge*
is the correct action there.

reminds everyone except the assignee to ignore it.

> I also decided to commit the script for building the gdb vm (marked as not
> working), we can just ignore it until we get around to fixing it. better
> than losing all the progress completely.

indeed. i trust it is based on the project standard dstro, debian/10?
(official use of anything else is prohibited, but if you *are* using
anything else *do not* encourage people to follow what you do.
if it includes anything other than debian/10 please remove it until
it does)

-- 
You are receiving this mail because:
You are on the CC list for the bug.