[Libre-soc-bugs] [Bug 1228] SFFS ISACaller userspace ELF support for dynamic linking and PIC and statically-linked-glibc
bugzilla-daemon at libre-soc.org
bugzilla-daemon at libre-soc.org
Tue Dec 12 18:48:11 GMT 2023
https://bugs.libre-soc.org/show_bug.cgi?id=1228
--- Comment #19 from Jacob Lifshay <programmerjake at gmail.com> ---
(In reply to Luke Kenneth Casson Leighton from comment #18)
> (In reply to Jacob Lifshay from comment #17)
>
> > oh, actually, i think i should change the failing test to skip and merge the
> > branch, this will help it from getting horribly out-of-date or forgotten.
> > sound good?
>
> good idea. or just leave it as a reminder.
>
> it is perfectly fine to have tests that fail. that's what
> they are there for, as reminders.
well, the problem with that is that CI won't show more than a few failing test
cases (otherwise the log is too long and gitlab truncates it, removing the test
summary), and also if we have too many, it's hard to find the tests we want
because they get lost in the noise of known-failing test cases.
>
> disabling tests "because fail" is actually extremely bad
> practice. think it through as to why.
disabling tests because you broke them and won't fix them is bad practice,
disabling tests because you never completed them and know that and have a bug
tracking them is imo fine.
I also decided to commit the script for building the gdb vm (marked as not
working), we can just ignore it until we get around to fixing it. better than
losing all the progress completely.
I'm pushing un-rebased to 1228-elf-dynamic:
https://git.libre-soc.org/?p=openpower-isa.git;a=shortlog;h=41f1911e9191b2e031e91f645c7e65884878ef7a
I tried to rebase on master, but something on master broke tons of tests
recently, somewhere between:
https://git.libre-soc.org/?p=openpower-isa.git;a=commit;h=8e9fdf5b4f9dfaee84665286c00b521c1f820b53
https://salsa.debian.org/Kazan-team/mirrors/openpower-isa/-/jobs/4998615
and
https://git.libre-soc.org/?p=openpower-isa.git;a=commit;h=5c672ca8e3e02fe4d441b48e8a9b35aa46150038
https://salsa.debian.org/Kazan-team/mirrors/openpower-isa/-/jobs/5013498
commit 41f1911e9191b2e031e91f645c7e65884878ef7a
Author: Jacob Lifshay <programmerjake at gmail.com>
Date: Tue Dec 12 10:20:03 2023 -0800
elf/simple_cases: disable case_static_glibc for now, re-enable when we work
on it again.
commit 94e0bc79a57037f41ee2410bfc70802815c22884
Author: Jacob Lifshay <programmerjake at gmail.com>
Date: Tue Dec 12 10:11:04 2023 -0800
add make_gdb_vm_image.sh script, it doesn't work yet but could be useful
see https://bugs.libre-soc.org/show_bug.cgi?id=1228#c15
--
You are receiving this mail because:
You are on the CC list for the bug.
More information about the libre-soc-bugs
mailing list