[Libre-soc-bugs] [Bug 644] MP3: Basic SV impl

[bugzilla-daemon at libre-soc.org]

https://bugs.libre-soc.org/show_bug.cgi?id=644

--- Comment #15 from Luke Kenneth Casson Leighton <lkcl at lkcl.net> ---
(In reply to cand from comment #14)
> They weren't intended for running the media tests, just as a sanity check
> the data matches on x86, etc.

yehyeh.  except, the idea for incrementing the loop size from 4 to 5
and excluding the bits that aren't needed with a predicate 0b01111,
that idea needs checking.

i mean the section at the end
    s0 = tmp[16];
    s1 = MULH3(tmp[17], icos36h[4], 2);
    ...

all of that can go inside the loop with for j = 0 j < **5**...
but its partner part can't (icos36[8-j) and s2 + s3), that would over-run
the array, so has to be predicated, hence 0b01111.

> So I wouldn't bind them into the main makefile
> tests at least. If you want to store modified versions, maybe with their own
> makefile target, that's fine.

ok good call.

-- 
You are receiving this mail because:
You are on the CC list for the bug.