[libre-riscv-dev] [Bug 316] bperm TODO

[bugzilla-daemon at libre-soc.org]

https://bugs.libre-soc.org/show_bug.cgi?id=316

--- Comment #8 from Cole Poirier <colepoirier at gmail.com> ---
(In reply to Luke Kenneth Casson Leighton from comment #7)
> (In reply to Cole Poirier from comment #6)
> you're not.  if the code is unused by anyone (which in this case it is),
> you cannot cause anyone else "damage" or "inconvenience"... therefore commit
> it.  right now.

Indeed I did misunderstand, thank you for correcting me. Unfortunately, I just
made the correction you suggested, and tried to push but I do not have push
access rights to the soc repo, only the dev-env-setup repo.

> > Additionally, pardon my ignorance, but are the unit tests supposed to 
> > be written inline or put in the tests directory of the working directory?
> 
> tests directory of the working directory.  in this case, soc/src/logical/test
> as "test_bperm.py" or something.
> 
> the very fact that you've cut/paste at least 3 variations into a *bugtracker*
> should tell you everything that you need to know.
> 
> and that if your hard drive were to become corrupted, the only way for you to
> recover the work would be.... to extract the code... *from these comments*.
> 
> that's s***, isn't it? :)
> 
> therefore, clearly, you must have misunderstood.

Very much so, I agree with your above logic, but due to my misunderstanding I
was very afraid to commit something because I mistakenly thought it could have
negative consequences.

> again, no need to set something to zero when, if it is not set, it will
> default *to* zero.
> 
> this btw only holds true for *combinatorial* logic.  sync logic you *must*
> do zero-setting (etc) where needed.

Thanks, I'll keep this in mind as I continue forwards, a very helpful tip!

> run python3 bperm.py generate -t il > bperm.il then use yosys to examine the
> graph (read_ilang bperm.il; show top)
> 
> it will be fascinating to see.

Ohhhboy... It worked! Very cool, however it is indeed a monster of a design

-- 
You are receiving this mail because:
You are on the CC list for the bug.