[libre-riscv-dev] nmutil failing tests due to attribute errors

[Luke Kenneth Casson Leighton]

On Wed, Mar 25, 2020 at 4:00 PM Cole Poirier <colepoirier at gmail.com> wrote:
>
> Hi Libre-SOC team,
>
> I think I completed HDL workflow sucessfully yesterday, however when I
> try to run "python3 setup.py test" in nmutil I get 33 errors.
> Adhering to the rule of not pasting large amounts of autogenerated
> output, I will only include two examples in this first email, but I can
> provide more details should you need them to help me. Can you please
> advise me as to what I've done wrong or misconfigured?
>
> ###
> ERROR: nmutil.test.test_outmux_pipe.test1
> AttributeError: 'Queue' object has no attribute 'we'

do a "git pull", i fixed this.  i thought i'd sorted it a few days ago
however that was in Queue itself, not singlepipe.py

> ERROR: nmutil.test.test_inout_unary_mux_cancel_pipe.test1
> AttributeError: 'TestInOutPipe' object has no attribute 'domains'

err.... err....

that works here, for me... and i think i know why.  it's because i
keep (temporarily) adding this to nmigen:

diff --git a/nmigen/compat/sim/__init__.py b/nmigen/compat/sim/__init__.py
index c6a89e3..42f6fd6 100644
--- a/nmigen/compat/sim/__init__.py
+++ b/nmigen/compat/sim/__init__.py
@@ -19,7 +19,7 @@ def run_simulation(fragment_or_module, generators,
clocks={"sync": 10}, vcd_name

     if not isinstance(generators, dict):
         generators = {"sync": generators}
-        fragment.domains += ClockDomain("sync")
+        #fragment.domains += ClockDomain("sync")

     sim = Simulator(fragment)
     for domain, period in clocks.items():

add that one line and it'll work.

l.