[libre-riscv-dev] making a Request for Payment

Luke Kenneth Casson Leighton lkcl at lkcl.net
Wed Jan 22 14:25:05 GMT 2020


On 1/22/20, Tobias Platen <tplaten at posteo.de> wrote:
> On Wed, 22 Jan 2020 13:41:27 +0000
> Luke Kenneth Casson Leighton <lkcl at lkcl.net> wrote:
>
>> On 1/22/20, Tobias Platen <tplaten at posteo.de> wrote:
>>
>> >> tobias i have some other questions, first, however.  will write them
>> >> up in a bit.  also please can you re-check-out the git repository
>> >> sv2nmigen, i removed the auto-generated files using a
>> >> git-filter-branch.
>> > Done
>>
>> star.  it's just good practice, the only exception i ever heard which
>> was reasonable was python checking in the configure script as well as
>> the configure.in.  the reason given was to ensure that re-running
>> autoconf never resulted in unexpected changes or dependencies on a
>> specific version *of* autoconf.
>>
>> also could you run pep8checker (or autopep8) and remove spaces at the
>> end of lines?  a recent annoying change to vim results in whitespace
>> being added and it's a pain in the neck that has to be kept an eye on.

> I ran autopep8 on python files inside sv2nmigen,

ah excellent.  that looks better.  it catches quite a lot of things
you wouldn't expect.

> and view all python scripts
> using emacs and whitespace-mode.

ahh ok, you use emacs.  not familiar with it.

> Using whitespace-mode I will see if tabs
> and spaces are mixed before actually running the script.

the convention for python (pep8) is: no tabs (ever) and to use 4
spaces (only) for indent.



More information about the libre-riscv-dev mailing list