[libre-riscv-dev] [Bug 172] partitioned signal add/sub/neg

bugzilla-daemon at libre-riscv.org bugzilla-daemon at libre-riscv.org
Wed Feb 12 15:02:09 GMT 2020


--- Comment #6 from Luke Kenneth Casson Leighton <lkcl at lkcl.net> ---
(In reply to Michael Nolan from comment #5)
> (In reply to Luke Kenneth Casson Leighton from comment #4)
> > oh wait... do you think you could update the docstring of PartitionedAdder,
> > make sure i got it right, and/or simply remove the table, replace it with
> > the link below (or "see wiki page listed at top of page") and edit that
> > instead?
> Updated


ah! spaces, michael! :)  i caught one in an earlier commit as well

+    exp-b    : 0BBBBIBBBBIBBBBIBBBBIBBBBc (32+2 bits plus 4 zeros)
+    exp-o    : o....oN...oN...oN...oN...x (32+4+2 bits - x to be discarded)
     o        :  .... N... N... N... N... (32 bits - x ignored, N is
-    carry-out:      o    o    o    o      (4 bits)
+    carry-out: o    o    o    o    o      (5 bits)
+    A couple of differences should be noted:

it may sound funny / pedantic however when you are looking at every single
person's diff (like i am) and the spaces show up in red, because if someone
uses a different editor then the whitespace mods end up as well and you
can't tell what's code and what's whitespace in a commit review, that becomes
a major distraction to the reviewer (and other code-readers).

please always always do a "git diff" prior to "git commit", skim-read it
all to the bottom, and you'll see that bash deliberately highlights
extraneous space in red.

i'll update the HDL workflow to match this.

You are receiving this mail because:
You are on the CC list for the bug.

More information about the libre-riscv-dev mailing list