[Libre-soc-bugs] [Bug 982] Support PowerPC ABI in ISACaller

[bugzilla-daemon at libre-soc.org]

https://bugs.libre-soc.org/show_bug.cgi?id=982

--- Comment #199 from Dmitry Selyutin <ghostmansd at gmail.com> ---
(In reply to Luke Kenneth Casson Leighton from comment #198)
>     def add_case(self, prog, initial_regs=None, initial_sprs=None,
>                  initial_cr=0, initial_msr=DEFAULT_MSR,
>                  initial_mem=None,
> 
> sorry i missed this.  this *has* to be initial_msr=None
> followed in ISACaller "if initial_msr is None: initial_msr=DEFAULT_MSR"
> 
> it is *not* ok to change the initial_msr to something that cannot
> be overridden. jacob can you remember the bugreport where this was
> discussed?

Jacob, I think this should be handled by you. First, it seems you're better
familiar with the rationale (I saw none; all I see is that default value is 0,
and nothing really expects None anywhere). Second, I don't even use add_case at
all, I haven't touched this place. Third, I pass initial MSR value from the
test directly.

-- 
You are receiving this mail because:
You are on the CC list for the bug.