[Libre-soc-bugs] [Bug 982] Support PowerPC ABI in ISACaller

bugzilla-daemon at libre-soc.org bugzilla-daemon at libre-soc.org
Sun Oct 22 16:09:45 BST 2023


https://bugs.libre-soc.org/show_bug.cgi?id=982

--- Comment #120 from Dmitry Selyutin <ghostmansd at gmail.com> ---
(In reply to Luke Kenneth Casson Leighton from comment #119)
> ok you notice how in comment #90 i did *not* pass in the "cheat"
> argument? that was deliberate. it means that the straight rfid
> pseudocode gets called, as-is.

It still is, even with passing syscall_emu_active parameter. :-) I just needed
something to check to make asmop be the same as ins_name; otherwise the code
thinks we met an illegal instruction.

illegal = ins_name != asmop

> redirecting hrfid to rfid will break hrfid when it is implemented,
> that should definitely not be done.

IIRC I did it since both evaluate to OP_RFID. But yes, this should be dropped.

> > https://git.libre-soc.org/?p=openpower-isa.git;a=commitdiff;
> > h=e25fca65a5a0faecdd9040689b5fe1f44b9a64a7
> 
> pass in "None" instead and do "if initial_msr is None:
> initial_msr=0x9000000000001" (MSR.LE | MSR.SF)

You mean ISACaller.__init__, right?

> > One this is done, almost everything works, except MSR check:
> > 
> > https://git.libre-soc.org/?p=openpower-isa.git;a=commitdiff;
> > h=dfec8c6456adfd3690d5d8da5a78fe3aa6c96b66
> 
> aaawesome.
> 
> okaay so now that value 0xfffffeeeablahblah that can be the expected
> e.msr!

So you mean that we actually got the correct value, it's just that my
expectations were incorrect?

> great! see comment #90 again (2nd from last paragraph).
> set e.msr = 0xfbfffffefd7f10c5 and we are pretty much done.

I'm confused. Comment #90 is my comment... :-) You probably meant something
else?

-- 
You are receiving this mail because:
You are on the CC list for the bug.


More information about the libre-soc-bugs mailing list