[Libre-soc-bugs] [Bug 1193] TrapTestCase.case_2_rfid is broken, without an obvious fix

[bugzilla-daemon at libre-soc.org]

https://bugs.libre-soc.org/show_bug.cgi?id=1193

--- Comment #5 from Jacob Lifshay <programmerjake at gmail.com> ---
(In reply to Luke Kenneth Casson Leighton from comment #4)
> (In reply to Jacob Lifshay from comment #2)
> 
> > yes, but in order for pytest/CI to properly test sc,
> 
> why are you using pytest in a mode that does not run all tests?

it does run all tests, but only when they all pass. this is because pytest runs
what it sees as a single test: running test_caller_trap.TrapTest.test (trapped
by __init__ so it runs TestRunnerBase.run_test instead)

this is worked around by the case_* machinery running everything under
self.subTest() ...

> what is the point of that?
... but I didn't install the subtests plugin for pytest (iirc something ran out
of ram, maybe vscode's pytest integration). It didn't occur to me to add that
plugin to CI since I expected we'd be proactive about fixing broken tests
(sadness...)

> 
> 
> >  the other cases in the
> > same class need to pass, otherwise they stop the test early and later cases
> > don't get run. This is because pytest treats the whole class as a unit.
> 
> then fix that in the CI so that they are all run!

ok, I'll work on that tomorrow. creating a bug...

-- 
You are receiving this mail because:
You are on the CC list for the bug.