[Libre-soc-bugs] [Bug 1066] fix bug where pseudo-code assignments modify more than just the variable being assigned to

[bugzilla-daemon at libre-soc.org]

https://bugs.libre-soc.org/show_bug.cgi?id=1066

--- Comment #9 from Jacob Lifshay <programmerjake at gmail.com> ---
(In reply to Luke Kenneth Casson Leighton from comment #8)
> (In reply to Jacob Lifshay from comment #7)
> >
> > commit da17d8d36e95bff174cee28eb316420c1c80b2b3
> > Author: Jacob Lifshay <programmerjake at gmail.com>
> > Date:   Thu Oct 19 18:00:55 2023 -0700
> > 
> >     skip broken test
> 
> do not do that.

as mentioned in bug #1193 comment #3, I reverted it.

>    
> >     it wasn't obvious how to fix it, see
> 
> if i had said it was needed i would have said "and do test_rfid"
> 
> > https://bugs.libre-soc.org/show_bug.cgi?id=1193
> 
> please close this bug as invalid once the skip is reverted, as
> unauthorized work.

I disagree, it is a valid bug because the test fails. adding skip_case being
unauthorized doesn't mean it isn't a problem that needs to eventually be fixed
by removing or correcting the test and/or correcting the simulator.
> 
> > commit 4280c97f2041ce4b61b183067e708c3cc7f9727a
> > Author: Jacob Lifshay <programmerjake at gmail.com>
> > Date:   Thu Oct 19 17:49:04 2023 -0700
> > 
> >     fill in manually verified expected state for
> > TrapTestCase.case_2_kaivb_test
> 
> this is good but unnecessary work. KAIVB is not an
> Authorized addition to the Power ISA.

yup, just fixing it so pytest will try to run the sc test.

-- 
You are receiving this mail because:
You are on the CC list for the bug.