[Libre-soc-bugs] [Bug 1193] TrapTestCase.case_2_rfid is broken, without an obvious fix

[bugzilla-daemon at libre-soc.org]

https://bugs.libre-soc.org/show_bug.cgi?id=1193

--- Comment #3 from Jacob Lifshay <programmerjake at gmail.com> ---
(In reply to Jacob Lifshay from comment #2)
> (In reply to Luke Kenneth Casson Leighton from comment #1)
> > please remove that. it works as compatible with microwatt.
> > if you remove tat test it could damage TestIssuer.
> 
> ok, well in that case, microwatt is just wrong, since it's in privileged
> mode, not problem mode (unless reserved MSR bits 1:2 are causing the trap).
> I'll revert that skip_case commit.

reverted:
https://git.libre-soc.org/?p=openpower-isa.git;a=commitdiff;h=fb9d0848913af3389f572497992e37883ea7b99c

the commit message where the expected state for case_2_rfid was added makes me
think you added whatever made the soc tests happy at the time, rather than what
matched microwatt:

https://git.libre-soc.org/?p=openpower-isa.git;a=commitdiff;h=cf8eaed82a022f2de46e8a4a358b211aefddb0d7

this is when you were working on https://bugs.libre-soc.org/show_bug.cgi?id=859

microwatt's privileged tests do give pc=0x700, but only because they set
Problem state and try to run rfid, which traps because it is privileged.

https://github.com/antonblanchard/microwatt/blob/63d4553faeea897926f89eb7486dd991cd9e83c8/tests/privileged/privileged.c#L215
https://github.com/antonblanchard/microwatt/blob/63d4553faeea897926f89eb7486dd991cd9e83c8/tests/privileged/privileged.c#L174

-- 
You are receiving this mail because:
You are on the CC list for the bug.