[Libre-soc-bugs] [Bug 1066] fix bug where pseudo-code assignments modify more than just the variable being assigned to

[bugzilla-daemon at libre-soc.org]

https://bugs.libre-soc.org/show_bug.cgi?id=1066

--- Comment #7 from Jacob Lifshay <programmerjake at gmail.com> ---
(In reply to Jacob Lifshay from comment #6)
> ok, I'll work on re-adding copy_assign_rhs and ensure the syscall tests
> still work.
> 
> I'll work on this soon, probably later today.

Done, I pushed to programmerjake/readd-rhs-copy, all tests pass except for the
ones I expect to fail (they started failing a long time ago). Since it works
can I push to master?

test failures:
> FAILED src/openpower/decoder/isa/test_caller_syscall.py::TestSysCall::test - ...
> FAILED src/openpower/sv/trans/test_pysvp64dis.py::SVSTATETestCase::test_20_cmp
> FAILED src/openpower/sv/trans/test_pysvp64dis.py::SVSTATETestCase::test_36_extras_rldimi_
> FAILED src/openpower/sv/trans/test_pysvp64dis.py::SVSTATETestCase::test_37_extras_rldimi
> FAILED src/openpower/sv/trans/test_pysvp64dis.py::SVSTATETestCase::test_36_extras_rldimi

https://git.libre-soc.org/?p=openpower-isa.git;a=shortlog;h=c3fe6beac9acce833c3e140b967000814d422998

commit c3fe6beac9acce833c3e140b967000814d422998
Author: Jacob Lifshay <programmerjake at gmail.com>
Date:   Thu Oct 19 18:18:51 2023 -0700

    Revert "Revert "fix bug where pseudo-code assignments modify more than just
the variable being assigned to""

    we need copy_assign_rhs

    See https://bugs.libre-soc.org/show_bug.cgi?id=1066

    This reverts commit bd3b54e83101217dc32da09083c6a3858fd7c600.

commit 4780418b01cc894aa817074bd3aaa7facffa074f
Author: Jacob Lifshay <programmerjake at gmail.com>
Date:   Thu Oct 19 18:17:20 2023 -0700

    Revert "fix bug introduced by having to revert unauthorized addition of"

    we need copy_assign_rhs

    See https://bugs.libre-soc.org/show_bug.cgi?id=1066

    This reverts commit 9dab88318a2938f14873804d83bf85ef9ae2fb93.

commit da17d8d36e95bff174cee28eb316420c1c80b2b3
Author: Jacob Lifshay <programmerjake at gmail.com>
Date:   Thu Oct 19 18:00:55 2023 -0700

    skip broken test

    it wasn't obvious how to fix it, see
https://bugs.libre-soc.org/show_bug.cgi?id=1193

commit 4280c97f2041ce4b61b183067e708c3cc7f9727a
Author: Jacob Lifshay <programmerjake at gmail.com>
Date:   Thu Oct 19 17:49:04 2023 -0700

    fill in manually verified expected state for TrapTestCase.case_2_kaivb_test

    based on the Programming Note on left side of PowerISA v3.1B page 1289
(1315)

commit ad85f6ae361b87d4f705c48a6fb300ee5ce43c56
Author: Jacob Lifshay <programmerjake at gmail.com>
Date:   Thu Oct 19 17:37:34 2023 -0700

    format code

-- 
You are receiving this mail because:
You are on the CC list for the bug.