[Libre-soc-bugs] [Bug 1177] New: revert unauthorized change to pseudocode language

[bugzilla-daemon at libre-soc.org]

https://bugs.libre-soc.org/show_bug.cgi?id=1177

            Bug ID: 1177
           Summary: revert unauthorized change to pseudocode language
           Product: Libre-SOC's first SoC
           Version: unspecified
          Hardware: PC
                OS: Linux
            Status: CONFIRMED
          Severity: enhancement
          Priority: ---
         Component: Source Code
          Assignee: lkcl at lkcl.net
          Reporter: lkcl at lkcl.net
                CC: libre-soc-bugs at lists.libre-soc.org
   NLnet milestone: ---

the change to the pseudocode language parser was not discussed and not
authorized.

https://git.libre-soc.org/?p=openpower-isa.git;a=commitdiff;h=870f7f232

it needs immediate reversion.

the way to handle this particular case is to *always* initialize
the variable (RT).

    if vex_flag = 0 then
        RT <- result
        FPSCR.FPRF <- undefined(0b00000)
        FPSCR.FR <- inc_flag
        FPSCR.FI <- xx_flag
    else
        RT <- undefined(0)
        FPSCR.FR <- 0
        FPSCR.FI <- 0

if there is *genuinely* an intention to not make a modification
to RT based on whether vex_flag is set or unset then that is a
different matter, but to create this type of unauthorized change
*without discussion* is just not acceptable.

it has taken months to find this, it was purely by chance.

the change should have been *raised and discussed*.

you cannot continue to blithely go ahead with making these kinds of changes
jacob on a repeated systematic long-term basis without there being consequences

-- 
You are receiving this mail because:
You are on the CC list for the bug.