[Libre-soc-bugs] [Bug 845] binutils: drop svmagic and deal with the prefix instead

[bugzilla-daemon at libre-soc.org]

https://bugs.libre-soc.org/show_bug.cgi?id=845

--- Comment #13 from Luke Kenneth Casson Leighton <lkcl at lkcl.net> ---
(In reply to Dmitry Selyutin from comment #11)
> So, TL;DR: what I've been thinking of is kinda like InstructionDatabase
> class, which parses all CSVs, a collection of instructions (likely
> searchable by both name/opcode). This instruction database parses all CSVs
> and also has some intimate knowledge about bitsels, suffixes, etc.
> InstructionDatabase would keep a collection of Instruction instances; each
> Instruction would provide the data, including stuff which needs some
> calculations.

i like it. a better version of get_csv().

> For example, we calculate some SVP64 fields based on CSVs, but the
> calculations are hidden inside CSV parser (get_svp64_csv). Instead, this
> should be hidden inside Instruction class. Same applies to the opcode. Also,
> the logic with bitsels and similar stuff should be wrapped too, exactly like
> create_pdecode does, except that it doesn't need to create the actual
> decoder. :-)

bear in mind the,stuff i wrote in comment #12 applies to scalar 32bit
ops, absolutely nothing to do with svp64 at all... but yes, i agree.


> Also, I should apologize, I think the overall tone of the first message was
> unnecessarily harsh. I had to dig into this for almost two consecutive days
> (sleep and food excluded), so it made me somewhat impatient and nervous. :-)
> I'm sorry, please don't consider it personal.

pffh i recognise a stress-out when i see one because i do it all the time.
if you'd said "stress stress blah blah oh and it's YOUR fault totally" then
my alarms would be hitting the defcon 4 button, but i saw nothing to get
concerned about at all.  just a perfectly normal "aaaaaaa!" moment.

-- 
You are receiving this mail because:
You are on the CC list for the bug.