[Libre-soc-bugs] [Bug 845] binutils: drop svmagic and deal with the prefix instead

[bugzilla-daemon at libre-soc.org]

https://bugs.libre-soc.org/show_bug.cgi?id=845

--- Comment #11 from Dmitry Selyutin <ghostmansd at gmail.com> ---
So, TL;DR: what I've been thinking of is kinda like InstructionDatabase class,
which parses all CSVs, a collection of instructions (likely searchable by both
name/opcode). This instruction database parses all CSVs and also has some
intimate knowledge about bitsels, suffixes, etc. InstructionDatabase would keep
a collection of Instruction instances; each Instruction would provide the data,
including stuff which needs some calculations.

For example, we calculate some SVP64 fields based on CSVs, but the calculations
are hidden inside CSV parser (get_svp64_csv). Instead, this should be hidden
inside Instruction class. Same applies to the opcode. Also, the logic with
bitsels and similar stuff should be wrapped too, exactly like create_pdecode
does, except that it doesn't need to create the actual decoder. :-)

Also, I should apologize, I think the overall tone of the first message was
unnecessarily harsh. I had to dig into this for almost two consecutive days
(sleep and food excluded), so it made me somewhat impatient and nervous. :-)
I'm sorry, please don't consider it personal.

-- 
You are receiving this mail because:
You are on the CC list for the bug.