[Libre-soc-bugs] [Bug 492] New: losing Elaboratables in div fsm.py

bugzilla-daemon at libre-soc.org bugzilla-daemon at libre-soc.org
Tue Sep 15 11:23:18 BST 2020


            Bug ID: 492
           Summary: losing Elaboratables in div fsm.py
           Product: Libre-SOC's first SoC
           Version: unspecified
          Hardware: PC
                OS: Linux
            Status: CONFIRMED
          Severity: enhancement
          Priority: ---
         Component: Source Code
          Assignee: lkcl at lkcl.net
          Reporter: lkcl at lkcl.net
                CC: libre-soc-bugs at lists.libre-soc.org
   NLnet milestone: ---

class FSMDivCorePrevControl(PrevControl):
    def __init__(self, pspec):
        self.pspec = pspec
        self.data_i = CoreInputData(pspec)

these need to go.  and remove

        # override p and n
        self.p = FSMDivCorePrevControl(pspec)
        self.n = FSMDivCoreNextControl(pspec)

 replaced with:

   self.p.pspec = pspec
   self.p.data_i = CoreInputData(pspec)

the reason is because the destruction of the ControlBase p and n
"leaks" both memory and also interferes with nmigen's "module tracking"

You are receiving this mail because:
You are on the CC list for the bug.

More information about the libre-soc-bugs mailing list