[Libre-soc-bugs] [Bug 448] MUL pipeline unit tests

[bugzilla-daemon at libre-soc.org]

https://bugs.libre-soc.org/show_bug.cgi?id=448

--- Comment #44 from Cole Poirier <colepoirier at gmail.com> ---
(In reply to Luke Kenneth Casson Leighton from comment #43)
> (In reply to Cole Poirier from comment #42)
> 
> > Yes I'm having trouble with this, I set my max line length to 80 chars, and
> > ran autopep8 on it but I end up having the above atrocious formatting?
> 
> then you should have spotted that in the "git diff" prior to commit and
> fixed it!

Yes I *should* have, will do so going forwards.

> > Isn't autopep8 supposed to enforce 80 chars?
> 
> only if you set -a -a -a.

That perplexes me, I would think it should be the default. Oh well.

> >  I *can* manually review *every* time in an 80 char wide xterm, 
> 
> yes.  do this, please, every time.  it's what is expected.  you cannot just
> "arbitrarily commit without thought and proper review".
> 
> in particular: tools often do "damage".  it's therefore critically important
> to do a full review.
> 
> every single time.

Will do :)

-- 
You are receiving this mail because:
You are on the CC list for the bug.