[Libre-soc-bugs] [Bug 448] MUL pipeline unit tests

[bugzilla-daemon at libre-soc.org]

https://bugs.libre-soc.org/show_bug.cgi?id=448

--- Comment #6 from Luke Kenneth Casson Leighton <lkcl at lkcl.net> ---
(In reply to Cole Poirier from comment #4)
> (In reply to Luke Kenneth Casson Leighton from comment #2) 
> > then use the text file from the wiki.
> 
> This is the right approach, the method I was using was looking in the
> generated fixedarith.py, by looking at the wiki I got the MUL instructions
> that didn't start with mulxxx i.e. maddxxx.
> 
> In order to set the test up to run, jacob created a helper.py file,

irrelevant.

>  this
> doesn't exist in the MUL test dir. Jacob also created a DivPipeKind enum

irrelevant.

> because of the different DIV pipeline implementations. 

irrelevant.

> Overall I'm not sure
> how to properly use the api of the pipelines to write this test. 

irrelevant.

> If I commit
> what I have can you help me with this?

it's real simple.

from this file:

https://git.libre-soc.org/?p=soc.git;a=blob;f=src/soc/fu/div/test/test_pipe_caller_long.py;hb=HEAD

at this line number:

https://git.libre-soc.org/?p=soc.git;a=blob;f=src/soc/fu/div/test/test_pipe_caller_long.py;hb=HEAD#l11

copy that function

adapt it to do "mul" instead of "div".

add it to this file:

https://git.libre-soc.org/?p=soc.git;a=blob;f=src/soc/fu/mul/test/test_pipe_caller.py;hb=HEAD

that's all that's needed.

nothing more, nothing less.

-- 
You are receiving this mail because:
You are on the CC list for the bug.