[libre-riscv-dev] [Bug 172] partitioned signal add/sub/neg

bugzilla-daemon at libre-riscv.org bugzilla-daemon at libre-riscv.org
Wed Feb 12 15:55:38 GMT 2020


--- Comment #9 from Luke Kenneth Casson Leighton <lkcl at lkcl.net> ---
(In reply to Michael Nolan from comment #8)
> > ah! spaces, michael! :)  i caught one in an earlier commit as well
> > (src/ieee754/part_shift_scalar/formal/proof_shift_scalar.py)
> ARGH! I added a pre-commit hook that runs flake8 with the trailing
> whitespace and line width warnings to catch exactly this, but it looks like
> I don't have it configured quite right (there's a separate warning for the
> whitespace on a blank line)


it's a useful thing to do to get into the habit of always typing "git diff"
prior to literally every "git commit" even if it's just to skim-read.

with the [justifiably-breakable-] rule being "keep commits reasonable and
small(-ish)" this isn't burdensome at all.

it also means you get to see exactly what you've done, right before you
start typing up the git commit message.

You are receiving this mail because:
You are on the CC list for the bug.

More information about the libre-riscv-dev mailing list