[libre-riscv-dev] buffered pipeline

Luke Kenneth Casson Leighton lkcl at lkcl.net
Mon Mar 25 08:51:41 GMT 2019


On Mon, Mar 25, 2019 at 8:34 AM Jacob Lifshay <programmerjake at gmail.com> wrote:
>
> pip install typing_extensions

 ok good... that fixed it...

 can the use of typing be taken out and moved to a .pyi file so that
it doesn't interfere with readability, doesn't make this
typing_extensions a hard requirement, and doesn't increase the
verbosity of the code?

 i'm having a hard time reading the code.  where normally i would
expect this to be on a single line:

        def visitor(name, pred_tuple, succ_tuple, buffer_tuple):

instead i'm trying much harder than it is necessary to do so to even
identify where or even what the names of the arguments actually are:

        def visitor(name: str,
                    pred_tuple: Tuple[Signal, Direction],
                    succ_tuple: Tuple[Signal, Direction],
                    buffer_tuple: Tuple[Signal, Direction]) -> None:

l.



More information about the libre-riscv-dev mailing list