[libre-riscv-dev] [PATCH] Adding some test cases, cleaning up macros.

Luke Kenneth Casson Leighton lkcl at lkcl.net
Thu Nov 15 08:50:25 GMT 2018


ok so that works, and is now pushed.  i apologise, i made some
modifications, it will result in conflicts.  sorry!

one recommendation: if a commit message has to use the word "and" to
describe purposes plural, it really should be split into two separate
commits (two separate patches in this case).


 so now it's possible to go through the unit tests, removing
SV_ELWIDTH_TEST from other files, the only thing being, there are two
variants needed: one which calls SVV_LDD_DATA and another which calls
SV_LD_DATA (plus an offset), as in some cases i cut/paste the macro
and modified it to take 32-bit data, others it's 64-bit.

 so, one thing at a time (always one thing at a time), would you like
to identify any file where the SV_ELWIDTH_TEST macro is used (grep
SV_ELWIDTH_TEST */*.S), then check it line-by-line to make absolutely
sure it's exactly the same (apart from the addition of the new code
and testdata arguments), then make that file use the (new)
SV_ELWIDTH_TEST?

 l.



More information about the libre-riscv-dev mailing list